update to renamed product doesn't work (completely)

[martinlippert]

on macOS:

Updating 4.29.1 to the latest snapshots of 4.30.0 causes the macOS apps to not start anymore with an error message. The reason seems to be that p2 does not remove the old native launcher executable from the MacOS folder in the installation. After removing the old launcher executable, everything seems to work fine again.

I filed a p2 issue for this:
eclipse-equinox/p2#787

Second observation:
The app is still called SpringToolSuite4.app, this piece haven't been renamed to SpringToolsForEclipse.app.

To investigate:
How does the update work on Windows / Linux?

[BoykoAlex]

It might be dependent on how you upgrade... If I touch the branding bundles (e.g. select all) updates tries to find an optimal upgrade and shows a dialog at the end with what is going to be installed, uninstalled and upgraded. If I select the second radio button to keep my installation compatible with what I'm installing I get everything upgraded properly on Windows with new product splash screen etc. The executable changes so it cannot start automatically when I restart but manually launching the new executable shows everything is working as expected.

The same gives me an error on mac:

[martinlippert]

I am rolling back this launcher name change for the upcoming 4.30.0 release to allow for a smooth upgrade experience to 4.30.0 while we keep this open to solve the underlying issue or find a proper workaround for the 4.31.0 release.

[martinlippert]

It looks like there is no easy solution to this (eclipse-equinox/p2#787), so we should keep the old launcher name around and wait for the rename of the launcher for the next major release, when we can ask people to start with a fresh installation instead of upgrading an existing one.