Skip to content

add variable styles #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2016
Merged

add variable styles #37

merged 1 commit into from
Jul 28, 2016

Conversation

dotcode
Copy link
Contributor

@dotcode dotcode commented Jul 26, 2016

No description provided.

@alexkilgour
Copy link
Contributor

Looks good 👍

@danyalaytekin
Copy link
Contributor

Looks good. Something to consider for another section/document is ES6. On Oscar when using ES6 we eradicated var in favour of let, as well as using const wherever possible.

@dotcode dotcode merged commit a17a260 into master Jul 28, 2016
@dotcode
Copy link
Contributor Author

dotcode commented Jul 28, 2016

Good point @danyalaytekin - have created #48

@josebolos josebolos deleted the javascript-variables branch February 15, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotcode @alexkilgour @danyalaytekin