Skip to content

Replace hardcoded strings with customizable attributes in multiple components #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2025
Merged

Replace hardcoded strings with customizable attributes in multiple components #893

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f3539e
Update shell.handlebars
amrutadotorg Apr 24, 2025
08ef7fb
Update table.handlebars
amrutadotorg Apr 24, 2025
8dcb781
Update 01_documentation.sql
amrutadotorg Apr 24, 2025
ddd0083
avoid failing tests on long loading map tiles
lovasoa Apr 24, 2025
64c801e
add an example for search_placeholder
lovasoa Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update shell.handlebars 
adding two options:
search_button
search_placeholder
  • Loading branch information
@amrutadotorg
amrutadotorg authored Apr 24, 2025
commit 6f3539e7f86c1ddd8eff5a9a366e16068d9e2f9e
4 changes: 2 additions & 2 deletions sqlpage/templates/shell.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@
</ul>
{{#if search_target}}
<form class="d-flex" role="search" action="{{search_target}}">
<input class="form-control me-2" type="search" placeholder="Search" aria-label="Search" name="search" value="{{search_value}}">
<button class="btn btn-outline-success" type="submit">Search</button>
<input class="form-control me-2" type="search" placeholder="{{default search_placeholder 'Search'}}" aria-label="Search" name="search" value="{{search_value}}">
<button class="btn btn-outline-success" type="submit">{{default search_button 'Search'}}</button>
</form>
{{/if}}
{{/inline}}
Expand Down