Ignore tokens that belong to array element declaration #3061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
reviewed
Aug 29, 2020
| T_OBJECT_CAST, | ||
| T_STRING_CAST, | ||
| T_UNSET_CAST, | ||
| ]; |
There was a problem hiding this comment.
You may want to use the preset Tokens::$castTokens array here.
|
@gsherwood what's your plan on reviewing this and other PRs? |
gsherwood
added a commit
that referenced
this pull request
Sep 21, 2020
gsherwood
added a commit
that referenced
this pull request
Sep 21, 2020
Just needed time mate. Thanks a lot for these fixes, and the detailed bug reports. |
gsherwood
added a commit
that referenced
this pull request
Sep 24, 2020
gsherwood
added a commit
that referenced
this pull request
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T_*_CASTto allow(cast) ...array elements. Fixes Squiz.Arrays.ArrayDeclaration false positive when using type casting #3059.T_STATICbeforeT_CLOSUREto allowstatic functionarray elements. Fixes Squiz.Arrays.ArrayDeclaration false positive for static functions #3060.