allow stdin fix to exit sucessfully #3541
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changing a return value would need to target a new major version (4.0 in this case), and that is already being tracked on issue #2898. Thanks for taking the time to write this PR, but I'm going to close it as a proper plan of the exit codes need to be made so they all make sense together. If you have a proposal, please drop it on that other issue to keep the discussion going. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting a file to phpcbf from stdin, phpcbf always fails.
I propose to make it succeed (exit 0) when no errors were found, given that cbf has no direct concept of "non-fixable errors".
It would allow tools to swap content of a buffered file when exit code is non-zero, and discard if nothing has been fixed.