This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: object, Fix tag message decoding #1104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Decode method was adding one too many newlines to the tag message, causing signature verification to fail. This is because in signed tags produced by `git`, there is a newline after the PGP signature block, resulting in `messageAndSig` having one extra (empty) `[]byte` element. This caused `t.Message` to receive one extra newline. Signed-off-by: Spencer Judd <[email protected]>
scjudd
force-pushed
the
bug/tag-decoding-newlines
branch
from
92b7efb to
de42463
Compare
scjudd
changed the title
|
Can you provide a test? Thanks! |
This was referenced Apr 15, 2019
|
Included in #1118 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Decodemethod was adding one too many newlines to the tag message, causing signature verification to fail. This is because in signed tags produced bygit, there is a newline after the PGP signature block, resulting inmessageAndSighaving one extra (empty)[]byteelement. This causedt.Messageto receive one extra newline.