This repository was archived by the owner on Sep 11, 2020. It is now read-only.
plumbing: format/commitgraph, rename structs/fields to follow the terms used by git more closely #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Navara <[email protected]>
…ms used by git more closely Signed-off-by: Filip Navara <[email protected]>
filipnavara
force-pushed
the
commitgraph-fmt-3
branch
from
a70e102 to
2123c53
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1128 and #1133 (included now, will rebase). Conflicts with #1132 (will rebase/update depending on whichever one gets in first).
This introduces two changes:
NodetoCommitData, which is the actual name in the git documentation. Since it's anticipated that more data will eventually be added to the format in form of new chunks it seems like a good idea to name the data structures after the chunks.large edgestoextra edgesto follow git change. This is restricted purely to the private functions and has no effect on the exported API.It is anticipated that commit-graph format v2 will land in git soon. I'll submit another PR to add support for it (to be merged once the change lands to git).