feat(stackable-versioned): Generate downgrade From impls #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techassi
force-pushed
the
feat/stackable-versioned-downgrade-from-impls
branch
from
53fe2c7 to
3fc0b82
Compare
Techassi
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
sbernauer
requested changes
May 16, 2025
|
|
||
| k8s-openapi.workspace = true | ||
| kube.workspace = true |
There was a problem hiding this comment.
TODO: Check if this is needed
| @@ -240,13 +240,13 @@ impl CommonItemAttributes { | |||
|
|
|||
| // The convert_with argument only makes sense to use when the | |||
There was a problem hiding this comment.
Suggested change
| // The convert_with argument only makes sense to use when the | |
| // The upgrade_with argument only makes sense to use when the |
| @@ -240,13 +240,13 @@ impl CommonItemAttributes { | |||
|
|
|||
| // The convert_with argument only makes sense to use when the | |||
| // type changed | |||
| if let Some(convert_func) = change.convert_with.as_ref() { | |||
| if let Some(upgrade_func) = change.upgrade_with.as_ref() { | |||
| if change.from_type.is_none() { | |||
| errors.push( | |||
| Error::custom( | |||
| "the `convert_with` argument must be used in combination with `from_type`", | |||
There was a problem hiding this comment.
Suggested change
| "the `convert_with` argument must be used in combination with `from_type`", | |
| "the `upgrade_with` argument must be used in combination with `from_type`", |
| @@ -240,13 +240,13 @@ impl CommonItemAttributes { | |||
|
|
|||
| // The convert_with argument only makes sense to use when the | |||
| // type changed | |||
| if let Some(convert_func) = change.convert_with.as_ref() { | |||
| if let Some(upgrade_func) = change.upgrade_with.as_ref() { | |||
There was a problem hiding this comment.
we need the same code block for downgrade pls
| )] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct #status_ident { | ||
| pub crd_values: #versioned_crate::CrdValues, |
There was a problem hiding this comment.
TODO: Think about a better name
| pub status: #status, | ||
| } | ||
| }), | ||
| None => Some(quote! { |
There was a problem hiding this comment.
We should combine the variants and only conditionally have
#[serde(flatten)]
pub status: #status,
| @@ -391,4 +465,52 @@ impl Struct { | |||
| _ => None, | |||
| } | |||
| } | |||
|
|
|||
| pub fn generate_kubernetes_status_struct(&self) -> Option<TokenStream> { | |||
| match &self.common.options.kubernetes_options { | |||
There was a problem hiding this comment.
let kubernetes_options = self.common.options.kubernetes_options.as_ref()?; instead pls
Comment on lines
+359
to
+365
| let status = if multiple_versions { | ||
| let status_ident = format_ident!( | ||
| "{struct_ident}Status", | ||
| struct_ident = self.common.idents.kubernetes.as_ident() | ||
| ); | ||
| Some(quote! { , status = #status_ident }) | ||
| } else { |
There was a problem hiding this comment.
I would prefer to either wait with the merge until the Status structure is proven to be working or comment this code out or put it behind an opt-in
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to downgrade CRDs.
#[versioned()]macro generatesFromimpls for downgrading.convert_withparameter of thechanged()action accordingly to support customizing both the upgrade and downgrade conversion function. There are now two separate parameters:upgrade_withanddowngrade_with.