Skip to content

Conversation

@johnsca
Copy link
Contributor

@johnsca johnsca commented Oct 4, 2023

The change in #37 (specifically, this line) means that the SinistralFormat class attribute will never be set, so we should use the local var instead.

The change in #37 means that the SinistralFormat class attribute will
never set, so we should use the local var instead.
Copy link
Contributor

@kapilt kapilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@johnsca johnsca merged commit b59fbd1 into main Oct 4, 2023
@johnsca johnsca deleted the johnsca/fix/run-command-project-name branch October 4, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants