Resolve "$def" for nested tool arg type #8534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenmoneygithub
force-pushed
the
fix-json-resolve
branch
from
8d3de63 to
8813049
Compare
TomeHirata
reviewed
Jul 16, 2025
tests/adapters/test_tool.py
Outdated
| async def async_complex_dummy_function( | ||
| profile: UserProfile, priority: int, notes: str | None = None | ||
| ) -> dict[str, Any]: | ||
| async def async_complex_dummy_function(profile: UserProfile, priority: int, notes: str | None = None) -> dict[str, Any]: |
Collaborator
There was a problem hiding this comment.
Is it intentional to keep notes here an optional str?
Collaborator
Author
There was a problem hiding this comment.
good catch!
TomeHirata
reviewed
Jul 16, 2025
| assert tool.args["profile"]["properties"]["contact"]["type"] == "object" | ||
| assert tool.args["profile"]["properties"]["contact"]["properties"]["email"]["type"] == "string" | ||
|
|
||
| # Reference should be resolved for nested pydantic models |
Collaborator
There was a problem hiding this comment.
nit: it's totally fine as it is, but since the expected json schema is somehow complex, it might be more readable if we define the entire dict and assert assert tool.args == expected_schema
Collaborator
Author
There was a problem hiding this comment.
This is actually intentional, I tried to use the expected_schema, but realized it was too long to be readable. So I moved back to the dedicated fields' check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when an argument is of type
list[MyPydanticModel], then$defwill be kept inside the json schema. To talk to the LM, we should fully resolve these references.