basic typescript definitions

[bsouthga]

Not sure if this is something you want in this lib @stasm, but these are the type definitions I used for innerself-hn and thought others might find them useful.

Alternatively we could publish them on DefinitivelyTyped, but its always nice to have them in the repo.

[stasm]

Cool, I'm all for adding this to the repo, thanks! I don't have much experience with TypeScript, so excuse me if my question below is silly ^^.

[stasm]

With this line here, are the other declarations using generics needed?

[bsouthga]

This is sort of an unfortunate property of typescript lacking "variadic kinds", which is basically typed spread arguments.

If we only have the last signature, than any connected components will always have the function signature (...args: any[]) => string instead of specific argument types.

For example, say we have a component like the following

const SayHi = (state: State, name: string) => html`
  <div>
    hey ${name}, check out this state prop ${ state.prop }
  </div>
`;

and then connect it

const ConnectedSayHi = connect(SayHi);

// if we only have the last signature, this will not error,
// as the signature is (...args: any[]) => string
ConnectedSayHi(10);

// however, if we have the over loaded signature, 
// then connected components with 3 or fewer arguments 
// will have their arguments typechecked...
ConnectedSayHi(10) // type error, as the signature is (a: string) => string;

[bsouthga]

the current annotation basically says... If the connected function has 3 or fewer arguments, create a new function with the same arguments (minus state), otherwise just type it as (...args: any[]) => string

[stasm]

Thanks for the explanation. This makes sense to me now.

[stasm]

Nit: please add a newline at the end of the file here.

[bsouthga]

one other thought on this, might want to wait until we figure out if connect might change after discussion in #19

[haoxins]

@stasm can we merge this PR now?