Skip to content

feat: add C implementation for stats/base/dists/lognormal/skewness #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 6, 2025
Merged

feat: add C implementation for stats/base/dists/lognormal/skewness #4166

merged 6 commits into from
May 6, 2025
+1,296 −3

Conversation

manvith2003
Copy link
Contributor

@manvith2003 manvith2003 commented Dec 23, 2024 •
edited
Loading

Resolves #3757

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/lognormal/skewness along with relevant tests, docs, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@manvith2003
feat: add C implementation for stats/base/dists/lognormal/skewness
460f003 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 23, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 23, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/lognormal/skewness $\color{green}179/179$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}179/179$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter added the bot: Update Copyright Years Pull request needing the copyright years of its files updated. label May 5, 2025
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Update Copyright Years Pull request needing the copyright years of its files updated. labels May 5, 2025
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label May 5, 2025
@Planeshifter
chore: apply suggestions from code review
5f2f2ac 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
docs: remove comment
b206a24 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
Copy link
Member

/stdlib merge

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label May 6, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 6, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/lognormal/skewness`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4166
Closes: https://github.com/stdlib-js/stdlib/issues/3757

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label May 6, 2025
@Planeshifter Planeshifter merged commit 736fe31 into stdlib-js:develop May 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/lognormal/skewness
3 participants
@manvith2003 @stdlib-bot @Planeshifter