Skip to content

feat(stats): add C implementation for stats/base/dists/chi/variance #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 3, 2025
Merged

feat(stats): add C implementation for stats/base/dists/chi/variance #4591

merged 12 commits into from
May 3, 2025

Conversation

anandkaranubc
Copy link
Contributor

@anandkaranubc anandkaranubc commented Jan 5, 2025 •
edited
Loading

Resolves

#3499

Description

Purpose of this pull request

This pull request:

  • Adds a C implementation of the chi distribution's variance.
  • Includes benchmarks for the C implementation.
  • Provides examples demonstrating the usage of the chi distribution's variance in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other Information

Any other relevant information?

Requires #4514 to be merged first to implement stats/base/dists/chi/variance

Checklist

Please ensure the following tasks are completed before submitting this pull request:

@stdlib-js/reviewers

@anandkaranubc
feat: add the C src files
19a9881
@anandkaranubc
feat: add the C benchmark and example files
550f864
@anandkaranubc
feat: add the JS native files
224c7be
@anandkaranubc
build: added the json and gyp dependency files
3b1495d
@anandkaranubc
docs: update README with C API documentation
12fb313 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 5, 2025
@anandkaranubc anandkaranubc marked this pull request as draft January 7, 2025 21:16
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 7, 2025
@Planeshifter
Copy link
Member

@anandkaranubc C implementation for @stdlib/stats/base/dists/chi/mean is now available!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label May 1, 2025
@anandkaranubc
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot
Copy link
Contributor

stdlib-bot commented May 1, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/chi/variance $\color{green}164/164$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}164/164$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label May 1, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label May 1, 2025
anandkaranubc and others added 3 commits April 30, 2025 23:38
@anandkaranubc
chore: follow code conventions
5b2865f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
style: fix indentation
a32244e 
Signed-off-by: Karan Anand <[email protected]>
@anandkaranubc
chore: fix header file
70a677d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc anandkaranubc marked this pull request as ready for review May 1, 2025 06:56
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 1, 2025
@anandkaranubc anandkaranubc requested a review from Planeshifter May 1, 2025 06:56
@anandkaranubc
Update native.js
9a122fe 
Signed-off-by: Karan Anand <[email protected]>
@anandkaranubc anandkaranubc added the C Issue involves or relates to C. label May 1, 2025
Planeshifter
Planeshifter previously approved these changes May 3, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Planeshifter
docs: add missing period
f427aba 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter approved these changes May 3, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label May 3, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented May 3, 2025 •
edited by Planeshifter
Loading

PR Commit Message

feat(stats): add C implementation for `stats/base/dists/chi/variance`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4591
Closes: https://github.com/stdlib-js/stdlib/issues/3499
Ref: https://github.com/stdlib-js/stdlib/issues/4514

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Karan Anand <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 3, 2025
@Planeshifter Planeshifter merged commit 8b7ddc2 into stdlib-js:develop May 3, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neerajpathak07 Neerajpathak07 Neerajpathak07 left review comments

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/chi/variance
4 participants
@anandkaranubc @Planeshifter @stdlib-bot @Neerajpathak07