-
-
Notifications
You must be signed in to change notification settings - Fork 813
feat: add stats/incr/nanmmeanstdev
#6606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: add stats/incr/nanmmeanstdev
#6606
Conversation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Coverage Report
The above coverage report was generated for the changes in this PR. |
/stdlib update-copyright-years |
@saad-imran-dev, please update your pr title to:
to pass the pr title check. |
stats/incr/nanmmeanstdev
Co-authored-by: Shabareesh Shetty <[email protected]> Signed-off-by: Muhmmad Saad <[email protected]>
Co-authored-by: Shabareesh Shetty <[email protected]> Signed-off-by: Muhmmad Saad <[email protected]>
Signed-off-by: Muhmmad Saad <[email protected]>
// MODULES // | ||
|
||
var bench = require( '@stdlib/bench' ); | ||
var randu = require( '@stdlib/random/base/randu' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var randu = require( '@stdlib/random/base/randu' ); |
I think we don't need to use this package, instead we could just pass iteration number as input
|
||
b.tic(); | ||
for ( i = 0; i < b.iterations; i++ ) { | ||
v = acc( randu() ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v = acc( randu() ); | |
v = acc( i ); |
Same reason
<section class="notes"> | ||
|
||
## Notes | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Input values are **not** type checked. If non-numeric inputs are possible, you are advised to type check and handle accordingly **before** passing the value to the accumulator function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This specifies that non numeric inputs are allowed in this package
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the examples should be updated as we need to pass NaN
values too in the input, please refer other similar packages.
<!-- eslint no-undef: "error" --> | ||
|
||
```javascript | ||
var randu = require( '@stdlib/random/base/randu' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
@saad-imran-dev, I think your implementation is missing |
import { ArrayLike } from '@stdlib/types/array'; | ||
|
||
/** | ||
* If provided a value, the accumulator function returns an updated moving arithmetic mean and corrected sample standard deviation. If provided NaN or no value, the accumulator function returns the current moving arithmetic mean and corrected sample standard deviation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* If provided a value, the accumulator function returns an updated moving arithmetic mean and corrected sample standard deviation. If provided NaN or no value, the accumulator function returns the current moving arithmetic mean and corrected sample standard deviation. | |
* If provided a value, the accumulator function returns an updated moving arithmetic mean and corrected sample standard deviation. If provided `NaN` or no value, the accumulator function returns the current moving arithmetic mean and corrected sample standard deviation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and elsewhere
lib/node_modules/@stdlib/stats/incr/nanmmeanstdev/benchmark/benchmark.js
Show resolved
Hide resolved
Co-authored-by: Shabareesh Shetty <[email protected]> Signed-off-by: Muhmmad Saad <[email protected]>
Co-authored-by: Shabareesh Shetty <[email protected]> Signed-off-by: Muhmmad Saad <[email protected]>
Co-authored-by: Shabareesh Shetty <[email protected]> Signed-off-by: Muhmmad Saad <[email protected]>
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves #5591
Description
This pull request:
mmeanstdev
for handlingNaN
values. It ignores anyNaN
values passes in the accumulatorRelated Issues
This pull request:
stats/incr/nanmmeanstdev
#5591Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers