Skip to content

chore: address commit comments for commit 1e0529a (issue #6912) #6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2025
Merged

chore: address commit comments for commit 1e0529a (issue #6912) #6923

merged 1 commit into from
May 4, 2025

Conversation

LalitNarayanYadav
Copy link
Contributor

Resolves #6912 .

This PR addresses a commit comment for commit 1e0529a.

Changes Made:

  • Replaced a typographic (“smart”) quote with a standard ASCII quote (") in a comment explaining GitHub issue reference formats in .github/workflows/scripts/generate_pr_commit_message.
  • This change improves clarity and avoids confusion in regex documentation and parsing logic.

Checklist

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels May 4, 2025
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label May 4, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 4, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented May 4, 2025 •
edited by Planeshifter
Loading

PR Commit Message

chore: address commit comments for commit `1e0529a`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6923
Closes: https://github.com/stdlib-js/stdlib/issues/6912

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Lalit Narayan Yadav <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 694f362 into stdlib-js:develop May 4, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 1e0529a)
3 participants
@LalitNarayanYadav @stdlib-bot @Planeshifter