Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stm32duino/Arduino_Core_STM32
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 37e7df6
Choose a base ref
...
head repository: thijses/Arduino_Core_STM32
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e7d39cc
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 13, 2024

  1. Update platformio-build.py 

    this fixes a spaces-in-path error i got, because:
lines 371~373 produce (in my case):
'$PROJECT_DIR\boards/variants\BKS_H2O_1003400D\ldscript.ld'
which then gets translated to a full/absolute path, where the spaces in my windows username are not accounted for.
I added some quotes around the whole thing, which fixes it for me.
(some of the other path strings (which include an absolute path early on) do not suffer from this issue, so i suspect that someone has already attempted to prevent spaces-in-path errors by dynamically adding quotes at some point, but has not accounted for unparsed paths ('$PROJECT_DIR') when checking for spaces.)

Signed-off-by: Thijs van Liempd <[email protected]>
    @thijses
    thijses authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e7d39cc View commit details
    Browse the repository at this point in the history
Loading