Skip to content

Conversation

@ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Apr 20, 2020

Summary
HardwareTimer: specific F1 GPIO needs Alternate Function configuration

Fixes #1036

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm added the fix 🩹 Bug fix label Apr 20, 2020
@fpistm fpistm added this to the 1.9.0 milestone Apr 20, 2020
On F1 specifically, input alternate functions must configure GPIO
in input mode.
Example: on F103 PinMap_UART_RX
{PB_7, USART1, STM_PIN_DATA(STM_MODE_INPUT, GPIO_PULLUP, AFIO_USART1_ENABLE)},
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@treitmayr
Copy link

Your version of this fix works for me as well and fixes issue #1036. Thanks!

@fpistm fpistm merged commit 6f32b49 into stm32duino:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 🩹 Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[F1] Duty cycle / frequence measurement not working for AF pin

3 participants