style guide #49
Merged
style guide #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also add this to our linter: https://docs.astral.sh/ruff/rules/#flake8-logging-format-g |
Unshure
reviewed
May 19, 2025
Done. See revision. |
pgrayy
commented
May 19, 2025
Unshure
approved these changes
May 20, 2025
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
May 21, 2025
* style guide * lint: logging
Unshure
added a commit
that referenced
this pull request
May 21, 2025
* fix: update direct tool call references to use agent.tool.tool_name format (#56) * Update README.md - corrected spelling of "model" (#59) Corrected spelling of model (s/modal/model) * style guide (#49) * style guide * lint: logging * Update version to 0.1.3 (#63) --------- Co-authored-by: ./c² <[email protected]> Co-authored-by: Bryan Samis <[email protected]> Co-authored-by: Patrick Gray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding style guide to cover preferences we do not yet have codified into our automatic linters.
Type of Change
Testing
hatch fmt --linterhatch fmt --formatterhatch test --allChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.