Skip to content

Conversation

@maxsxu
Copy link
Member

@maxsxu maxsxu commented Mar 27, 2023

Fixes #1024

Motivation

With the public and release of pulsar-admin-go, we can now adopt pulsar-admin-go and clean unused codes.

Modifications

This PR try best to do only below two things to avoid huge changes.

  • Use github.com/streamnative/[email protected]
  • Remove unused codes as they're implemented in pulsar-admin-go

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@maxsxu maxsxu requested a review from zymap as a code owner March 27, 2023 10:05
@maxsxu maxsxu self-assigned this Mar 27, 2023
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Mar 27, 2023
@maxsxu maxsxu marked this pull request as draft March 27, 2023 12:47
@maxsxu maxsxu force-pushed the max/pulsar-admin-go branch from 947c7b4 to a2ad832 Compare March 27, 2023 13:26
@maxsxu maxsxu marked this pull request as ready for review March 27, 2023 13:49
@maxsxu maxsxu requested a review from mattisonchao March 27, 2023 13:49
@maxsxu maxsxu merged commit 8fed82f into master Mar 27, 2023
@maxsxu maxsxu deleted the max/pulsar-admin-go branch March 27, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-need-doc This pr does not need any document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt pulsar-admin-go

4 participants