This repository was archived by the owner on Jun 28, 2019. It is now read-only.
Docの追加、内部処理改善 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nacatl
reviewed
Sep 14, 2018
| data?.also { | ||
| CertificationStore.create(context).update(it) | ||
| if (data == null) { | ||
| Log.e("StudyplusSDK", "The data is null. Please check your code. If the received data is already null, please contact Studyplus Dev team.") |
There was a problem hiding this comment.
個人的に already が違和感あるんですが、なんかうまく言い表せない…
If the data that received from Studyplus app is null,
の方が、 何がnullだったら をより正確に表せるような気はします
| fun postRecord(context: Context, studyRecord: StudyRecord, listener: OnPostRecordListener?) { | ||
| if (!isAuthenticated(context)) { | ||
| throw IllegalStateException("Please check your application's authentication before this method call.") |
There was a problem hiding this comment.
先に認証をチェックしてくれ と言うより 先に認証してくれ の方が自然な気がします
Please authenticate (your application) before this method call.
There was a problem hiding this comment.
SDKの利用デベロッパーに「チェックして認証されていなければ叩かない（先に認証してから叩く）」ことを通知したいため、こちらはこのメッセージでいきたいです。
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.