Replace <Type>x with x as Type (fixes #21)

[Xstoudi]

I wrote a script who replace every "expression" by "(expression as type)" (#21). It seems to work.

[elisee]

Looks good. Can you amend the commit message & force push your branch? As listed in the documentation:

• Use imperative in your commits message, for instance Add flux capacitor not Added a flux capacitor
• If you're fixing a bug with an existing issue number of GitHub, mention it in the commit message: Increase gigawatt output, closes #6

Something like Use "as" keyword for type assertions everywhere, fixes #21 would be great.

Thanks!

[elisee]

Did you try building Superpowers from source with your changes? There are quite a few errors because of misplaced parentheses ^_^.

For instance, in SupCore/Data/Base.index.ts:

• let items = (rule as string[]).items; Should have been: let items = rule.items as string[];
• (rule as Rule).items should have been rule.items as Rule

In SupCore/Data/Entries.ts, (this as EntryNode).byId[id] should have been this.byId[id] as EntryNode, etc.

Can you try updating the script to fix it, rebuilding and force pushing a corrected commit?

[Xstoudi]

(Sorry for the delay)
I have not managed to create a valid regexp to do this automatically, but the script can find the lines to change.
https://gist.github.com/Xstoudi/dd75d95e0a8a6f1d1c64

[Xstoudi]

You can close the other pull request, I failed to rebase...

[elisee]

By the other pull request, you mean this one, right?