-
Notifications
You must be signed in to change notification settings - Fork 40
Added time section for EIB, metal3 and elemental #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good @e-minguez - the one thing I'd recommend is that rather than using a |
Good suggestion! Changed, PTAL :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We could add a note about the fact that these are just examples, but I think I'm overthinking it.
But you are right and it won't hurt. Changed. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a comment but LGTM
6ad838f
Co-authored-by: Atanas Dinov <[email protected]> Co-authored-by: Alberto Morgante Medina <[email protected]>
|
Final check after committing @atanasdinov and @alknopfler suggestions (thanks) |
We've been receiving some complains (especially on the elemental workflow) about things not working that turned out to be clock issues. Adding explicit docs will probably avoid similar issues in the future.