Skip to content

Conversation

@e-minguez
Copy link
Collaborator

@e-minguez e-minguez commented May 27, 2025

We've been receiving some complains (especially on the elemental workflow) about things not working that turned out to be clock issues. Adding explicit docs will probably avoid similar issues in the future.

@rdoxenham
Copy link
Contributor

Looks good @e-minguez - the one thing I'd recommend is that rather than using a pool.server.com example, perhaps we just use the default SUSE pool? 2.suse.pool.ntp.org as an example? That way, if people blindly copy configuration files, it should still largely work :)

@e-minguez
Copy link
Collaborator Author

Looks good @e-minguez - the one thing I'd recommend is that rather than using a pool.server.com example, perhaps we just use the default SUSE pool? 2.suse.pool.ntp.org as an example? That way, if people blindly copy configuration files, it should still largely work :)

Good suggestion! Changed, PTAL :)

rdoxenham
rdoxenham previously approved these changes May 27, 2025
Copy link
Contributor

@rdoxenham rdoxenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could add a note about the fact that these are just examples, but I think I'm overthinking it.

@e-minguez
Copy link
Collaborator Author

LGTM. We could add a note about the fact that these are just examples, but I think I'm overthinking it.

But you are right and it won't hurt. Changed. PTAL.

alknopfler
alknopfler previously approved these changes May 27, 2025
Copy link
Contributor

@alknopfler alknopfler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a comment but LGTM

rdoxenham
rdoxenham previously approved these changes May 27, 2025
atanasdinov
atanasdinov previously approved these changes May 27, 2025
@e-minguez e-minguez dismissed stale reviews from atanasdinov, rdoxenham, and alknopfler via 6ad838f May 27, 2025 09:45
atanasdinov
atanasdinov previously approved these changes May 27, 2025
Co-authored-by: Atanas Dinov <[email protected]>
Co-authored-by: Alberto Morgante Medina <[email protected]>
@e-minguez
Copy link
Collaborator Author

Final check after committing @atanasdinov and @alknopfler suggestions (thanks)

@e-minguez e-minguez merged commit 6fb6361 into suse-edge:main May 27, 2025
1 check passed
@e-minguez e-minguez deleted the warn_time branch May 27, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants