[6.2][CAS] Fix an off-by-one error in CAS validation #10596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
commented
Apr 30, 2025
cachemeifyoucan
commented
- Explanation: Fix a false positive in invalid CAS detection that when the last data stored in CAS just fits inside the DataPool, validation is erroneously think the data stored pass the end of the storage.
- Scope: Allows CAS validation and recovery correctly so the valid CAS doesn't get throw away
- Issues: rdar://150386374
- Original PRs: [CAS] Fix an off-by-one error in CAS validation #10595
- Risk: Low
- Testing: UnitTest
- Reviewers: @benlangmuir
Fix a false positive in invalid CAS detection that when the last data stored in CAS just fits inside the DataPool, validation is erroneously think the data stored pass the end of the storage. The error happens when the size of the data is alignment - 1, as the null termination padding will make the end of the data matches the end of the data pool. rdar://150386374
|
@swift-ci please test |
akyrtzi
approved these changes
Apr 30, 2025
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.