Skip to content

[20250402][LLDB] Fix build errors #10599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 2, 2025
Merged

[20250402][LLDB] Fix build errors #10599

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
0216bc5
[stable/20250402] Cherry-pick "[lldb] Update for PoundDiagnosticDecl …
rintaro Mar 8, 2025
4c80b27
[stable/20250402] Cherry-pick "[Swift] Update for TypeAliasType::get(…
slavapestov Dec 5, 2024
d3e7a33
[stable/20250402] Cherry-pick "[lldb] Upgrade CompilerType::GetBitSiz…
adrian-prantl Mar 6, 2025
3b5119d
[LLDB] Fix faulty merge
AnthonyLatsis Apr 30, 2025
8670119
[LLDB] Swift: Fix faulty cherry-pick
AnthonyLatsis Apr 30, 2025
1631026
[LLDB] Swift: Adjust use of `llvm::Module::setTargetTriple` (paramete…
AnthonyLatsis Apr 30, 2025
6add869
[LLDB] Swift: Refactor method override (parameter type changed)
AnthonyLatsis Apr 30, 2025
adc1439
[LLDB] Swift: Adjust method override (parameter type changed)
AnthonyLatsis Apr 30, 2025
4b679f0
[LLDB] Swift: Adjust method override (parameter type changed)
AnthonyLatsis Apr 30, 2025
273c1ad
[LLDB] Swift: Switch from `UnwindPlan::RowSP` to `UnwindPlan::Row`
AnthonyLatsis Apr 30, 2025
154efe7
[LLDB] Swift: Adjust call to `TypeSystemClang::GetMetadata` (return t…
AnthonyLatsis Apr 30, 2025
218e173
[LLDB] Swift: Add missing `TypeSummaryImpl::GetName` implementations
AnthonyLatsis Apr 30, 2025
0ce4444
[LLDB] Swift: Adjust includes of moved Clang headers
AnthonyLatsis May 1, 2025
826c36e
[LLDB] Swift: Adjust calls to moved & renamed methods
AnthonyLatsis May 1, 2025
8a94a74
[LLDB] Swift: s/DWARFRangeList/llvm::DWARFAddressRangeVector
AnthonyLatsis May 1, 2025
1a10d6b
[LLDB] Swift: Adjust call to `Function::GetStartLineSourceInfo` (para…
AnthonyLatsis May 1, 2025
26e0ab5
[LLDB] Swift: Refactor call to now `protected` method
AnthonyLatsis May 1, 2025
4bcd0b3
[LLDB] Swift: Add missing argument to call
AnthonyLatsis May 1, 2025
1e2b39f
[LLDB] Update bindings
AnthonyLatsis May 1, 2025
0b6504a
[LLDB] Swift: Refactor `TypeSystemSwiftTypeRef` after `CompilerContex…
AnthonyLatsis May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[LLDB] Swift: Refactor call to now protected method 
Per c4fb718.
  • Loading branch information
@AnthonyLatsis
AnthonyLatsis committed May 1, 2025
commit 26e0ab59846cec9a06898a414143e84ad5d1d8bf
3 changes: 1 addition & 2 deletions lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2905,8 +2905,7 @@ std::optional<SwiftNominalType> GetSwiftClass(ValueObject &valobj,

auto isa_load_addr = descriptor_sp->GetISA();
Address isa;
const auto &sections = objc_runtime.GetTargetRef().GetSectionLoadList();
if (!sections.ResolveLoadAddress(isa_load_addr, isa))
if (!objc_runtime.GetTargetRef().ResolveLoadAddress(isa_load_addr, isa))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this forwarding the call to the SectionLoadList?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

return {};

// Next, iterate over the Module's symbol table, looking for a symbol with
Expand Down