Skip to content

🍒 [lldb] Remove CompilerType::GetIndexOfFieldWithName (#135963) #10641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: swift/release/6.2
Choose a base branch
from
Open

🍒 [lldb] Remove CompilerType::GetIndexOfFieldWithName (#135963) #10641

wants to merge 2 commits into from

Conversation

charles-zablit
Copy link

@charles-zablit
[lldb] Remove CompilerType::GetIndexOfFieldWithName (llvm#135963)
399bf57 
This patch removes the unused `CompilerType::GetIndexOfFieldWithName` API (it wasn't used apart from in a single testcase). Given we have so many similarly named APIs already, it's best not to maintain this API that's not really used (and isnt tested).
@charles-zablit charles-zablit requested a review from a team as a code owner May 8, 2025 11:31
@adrian-prantl
Copy link

@swift-ci test

@charles-zablit
Copy link
Author

I think the commit which introduces the ExecutionContext *exe_ctx, is not present in the upstream llvm-repo. I was not able to cherry-pick so I introduced a new commit which fixes the build error manually.

@adrian-prantl
Copy link

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-prantl adrian-prantl adrian-prantl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charles-zablit @adrian-prantl