Skip to content

[lldb] Disable statusline on Windows (#138111) #10647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[lldb] Disable statusline on Windows (llvm#138111)
Something to do with control code handling in Windows terminals breaks
the statusline in various ways. It makes LLDB unusable and even if you
set the setting to disable statusline, it's too late, and the terminal
session is now in a weird state.

See llvm#134846 for more details.

Until we figure this out, don't allow it to be used on Windows.

(cherry picked from commit 09488bc)
  • Loading branch information
DavidSpickett authored and JDevlieghere committed May 8, 2025
commit c240358d46745e1c95dd004608a832ee42c03d30
2 changes: 1 addition & 1 deletion lldb/source/Core/CoreProperties.td
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ let Definition = "debugger" in {
def ShowStatusline: Property<"show-statusline", "Boolean">,
Global,
DefaultTrue,
Desc<"Whether to show a statusline at the bottom of the terminal.">;
Desc<"Whether to show a statusline at the bottom of the terminal (not supported on Windows).">;
def Separator : Property<"separator", "String">,
Global,
DefaultStringValue<"│ ">,
Expand Down
4 changes: 4 additions & 0 deletions lldb/source/Core/Debugger.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2040,13 +2040,17 @@ void Debugger::CancelForwardEvents(const ListenerSP &listener_sp) {
}

bool Debugger::StatuslineSupported() {
// We have trouble with the contol codes on Windows, see
// https://github.com/llvm/llvm-project/issues/134846.
#ifndef _WIN32
if (GetShowStatusline()) {
if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) {
File &file = stream_sp->GetUnlockedFile();
return file.GetIsInteractive() && file.GetIsRealTerminal() &&
file.GetIsTerminalWithColors();
}
}
#endif
return false;
}

Expand Down