🍒 [clang][modules][deps] Optimize in-process timestamping of PCMs #10655
+109
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#137363) In the past, timestamps used for `-fmodules-validate-once-per-build-session` were found to be a source of contention in the dependency scanner ([D149802](https://reviews.llvm.org/D149802), llvm#112452). This PR is yet another attempt to optimize these. We now make use of the new `ModuleCache` interface to implement the in-process version in terms of atomic `std::time_t` variables rather the mtime attribute on `.timestamp` files.
|
@swift-ci please test |
cyndyishida
approved these changes
May 8, 2025
This patch fixes: clang/lib/Tooling/DependencyScanning/InProcessModuleCache.cpp:69:7: error: 'std::lock_guard' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported] clang/lib/Tooling/DependencyScanning/InProcessModuleCache.cpp:80:7: error: 'std::lock_guard' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported] clang/lib/Tooling/DependencyScanning/InProcessModuleCache.cpp:93:7: error: 'std::lock_guard' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, timestamps used for
-fmodules-validate-once-per-build-sessionwere found to be a source of contention in the dependency scanner (D149802, llvm#112452). This PR is yet another attempt to optimize these. We now make use of the newModuleCacheinterface to implement the in-process version in terms of atomicstd::time_tvariables rather the mtime attribute on.timestampfiles.