Skip to content

[CAS] OnDisk update/cleanup. NFCI. #11609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

[CAS] OnDisk update/cleanup. NFCI. #11609

wants to merge 1 commit into from

Conversation

cachemeifyoucan
Copy link

@cachemeifyoucan cachemeifyoucan commented Oct 9, 2025 •
edited
Loading

Noticeable changes:

  • Hide some forward declared types.
  • Rename all the files (switch the order prefix/suffix and reset version to v1) so we can reset the version while being compatible.
  • Change unit-test to properly set a smaller file size and just not building OnDiskCAS test when it is disabled.

@cachemeifyoucan
Copy link
Author

@swift-ci please test llvm

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-code-cleanup branch from 7950626 to 8ff887a Compare October 9, 2025 21:39
@cachemeifyoucan
Copy link
Author

@swift-ci please test llvm

@cachemeifyoucan
Copy link
Author

This is a clean up for upstream review. NFC.

@cachemeifyoucan cachemeifyoucan changed the title OnDisk update/cleanup [CAS] OnDisk update/cleanup. NFCI. Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akyrtzi akyrtzi Awaiting requested review from akyrtzi

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cachemeifyoucan