Skip to content

Allow running tests on Windows by using SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 14, 2024

Also, fix two minor Windows test failures.

ahoppen added a commit to ahoppen/swift-package-manager that referenced this pull request Oct 14, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module.

This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows.

See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
ahoppen added a commit to ahoppen/swift-format that referenced this pull request Oct 14, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module.

This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows.

See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
ahoppen added a commit to ahoppen/swift-format that referenced this pull request Oct 14, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module.

This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows.

See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
@ahoppen
Copy link
Member Author

ahoppen commented Oct 14, 2024

@swift-ci Please test

ahoppen added a commit to ahoppen/swift-format that referenced this pull request Oct 14, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module.

This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows.

See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
@ahoppen
Copy link
Member Author

ahoppen commented Oct 14, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Oct 14, 2024

@swift-ci Please test Windows

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented Oct 14, 2024

@swift-ci Please test Windows

ahoppen added a commit to ahoppen/swift-package-manager that referenced this pull request Oct 14, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module.

This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows.

See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
Package.swift Outdated
@@ -460,6 +458,13 @@ var installAction: Bool { hasEnvironmentVariable("SOURCEKIT_LSP_CI_INSTALL") }
/// remote dependency.
var useLocalDependencies: Bool { hasEnvironmentVariable("SWIFTCI_USE_LOCAL_DEPS") }

/// Whether swift-syntax is being built as a single dynamic library instead of as a separate library per module.
///
/// This means that the swift-syntax symbols don't need to be statically linked, which alles us to stay below the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// This means that the swift-syntax symbols don't need to be statically linked, which alles us to stay below the
/// This means that the swift-syntax symbols don't need to be statically linked, which allows us to stay below the

…BRARY`

Also, fix two minor Windows test failures.
@ahoppen
Copy link
Member Author

ahoppen commented Oct 14, 2024

@swift-ci Please test

ahoppen added a commit to ahoppen/swift-package-manager that referenced this pull request Oct 14, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module.

This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows.

See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
@ahoppen
Copy link
Member Author

ahoppen commented Oct 14, 2024

@swift-ci Please test Windows

@ahoppen ahoppen merged commit b9dd254 into swiftlang:main Oct 15, 2024
3 checks passed
@ahoppen ahoppen deleted the windows-tests branch October 15, 2024 00:40
ahoppen added a commit to swiftlang/swift-package-manager that referenced this pull request Oct 15, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change
swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic`
product instead of separate products for each module.

This allows us to build SourceKit-LSP on Windows using SwiftPM without
exceeding the maximum symbol limit and thus run SourceKit-LSP tests on
Windows.

See swiftlang/sourcekit-lsp#1754 and
swiftlang/swift-syntax#2879.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants