-
Notifications
You must be signed in to change notification settings - Fork 313
Allow running tests on Windows by using SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY
#1754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
added a commit
to ahoppen/swift-package-manager
that referenced
this pull request
Oct 14, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module. This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows. See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Oct 14, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module. This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows. See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Oct 14, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module. This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows. See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Oct 14, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module. This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows. See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
44b64ba
to
593422b
Compare
@swift-ci Please test |
@swift-ci Please test Windows |
1 similar comment
@swift-ci Please test Windows |
ahoppen
added a commit
to ahoppen/swift-package-manager
that referenced
this pull request
Oct 14, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module. This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows. See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
bnbarham
approved these changes
Oct 14, 2024
Package.swift
Outdated
@@ -460,6 +458,13 @@ var installAction: Bool { hasEnvironmentVariable("SOURCEKIT_LSP_CI_INSTALL") } | |||
/// remote dependency. | |||
var useLocalDependencies: Bool { hasEnvironmentVariable("SWIFTCI_USE_LOCAL_DEPS") } | |||
|
|||
/// Whether swift-syntax is being built as a single dynamic library instead of as a separate library per module. | |||
/// | |||
/// This means that the swift-syntax symbols don't need to be statically linked, which alles us to stay below the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
/// This means that the swift-syntax symbols don't need to be statically linked, which alles us to stay below the | |
/// This means that the swift-syntax symbols don't need to be statically linked, which allows us to stay below the |
…BRARY` Also, fix two minor Windows test failures.
593422b
to
6fe1481
Compare
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/swift-package-manager
that referenced
this pull request
Oct 14, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module. This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows. See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
@swift-ci Please test Windows |
ahoppen
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Oct 15, 2024
When `SWIFTSYNTAX_BUILD_DYNAMIC_LIBRARY` is specified, change swift-syntax dependencies to depend on a single `_SwiftSyntaxDynamic` product instead of separate products for each module. This allows us to build SourceKit-LSP on Windows using SwiftPM without exceeding the maximum symbol limit and thus run SourceKit-LSP tests on Windows. See swiftlang/sourcekit-lsp#1754 and swiftlang/swift-syntax#2879.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix two minor Windows test failures.