[DO NOT MERGE] Valgrind testing #479
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
force-pushed
the
eng/PR-valgrind-testing
branch
11 times, most recently
from
054ce2d to
52f5310
Compare
This just removes a bunch of calls that can trivially become async.
These just need simple synchronization; use a mutex instead. This also plugs a couple occurrences of unsynchronized access.
Stress testing this approach over use of a long-lived DispatchIO channel appears to resolve the nondeterministic failures with the file descriptor being destroyed, and is easier to reason about. Closes #21
jakepetroules
force-pushed
the
eng/PR-valgrind-testing
branch
2 times, most recently
from
c42b6d8 to
d9bc4d1
Compare
jakepetroules
force-pushed
the
eng/PR-valgrind-testing
branch
from
d9bc4d1 to
fed524e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.