Skip to content

Improve tracking dependencies of header generation. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025
Merged

Improve tracking dependencies of header generation. #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6277c7e
Improve tracking dependencies of header generation.
adetaylor Jul 9, 2025
280b532
Review comments.
adetaylor Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion 3_bidirectional_cxx_interop/cmake/modules/AddSwift.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ function(_swift_generate_cxx_header target header)
cmake_path(APPEND base_path ${header}
OUTPUT_VARIABLE header_path)

set(_AllSources $<TARGET_PROPERTY:${target},SOURCES>)
cmake_path(APPEND CMAKE_CURRENT_BINARY_DIR "${ARG_MODULE_NAME}.emit-module.d" OUTPUT_VARIABLE depfile_path)

set(_AllSources $<PATH:ABSOLUTE_PATH,$<TARGET_PROPERTY:${target},SOURCES>,${CMAKE_CURRENT_SOURCE_DIR}>)
set(_SwiftSources $<FILTER:${_AllSources},INCLUDE,\\.swift$>)
add_custom_command(OUTPUT ${header_path}
DEPENDS ${_SwiftSources}
Expand All @@ -61,6 +63,9 @@ function(_swift_generate_cxx_header target header)
-module-name "${ARG_MODULE_NAME}"
-cxx-interoperability-mode=default
-emit-clang-header-path ${header_path}
-emit-dependencies
DEPFILE "${depfile_path}"
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
COMMENT
"Generating '${header_path}'"
COMMAND_EXPAND_LISTS)
Expand Down