Skip to content

Conversation

jmschonfeld
Copy link
Contributor

@jmschonfeld jmschonfeld commented Dec 6, 2024

  • Explanation: Requesting the home directory for a non-existent user now returns nil as it used to instead of /var/empty or %ALLUSERSPROFILE%. The current user's home directory still falls back to /var/empty/%ALLUSERSPROFILE% as it has previously.
  • Scope: Impacts requesting the home directory for a username that does not exist across all platforms
  • Original PRs: Home directory for non-existent user should not fall back to /var/empty or %ALLUSERSPROFILE% #1072
  • Risk: Low-Medium - this does change behavior, however it restores swift 5.10 behavior, this is heavily tested by unit tests, and I don't expect this behavior to be fairly load bearing
  • Testing: local testing, swift-ci testing
  • Reviewers: @jrflat @kperryua

@jmschonfeld jmschonfeld requested a review from parkera December 6, 2024 23:56
@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld jmschonfeld merged commit 3a3d5dc into swiftlang:release/6.1 Dec 12, 2024
3 checks passed
@jmschonfeld jmschonfeld deleted the 6.1/nonexistent-user-home-dir branch December 12, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants