[6.1] Fix WASI build of _copyDirectoryMetadata
#1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended attributes don't exist in WASI, so we need to exclude the use of xattr-related APIs including `flistxattr`.
* Gate `fchown` and `fchmod` calls behind `os(WASI)` They are not available on WASI, so we gate them behind `os(WASI)`. * Add missing constant shims for wasi-libc * Use `futimens` instead of legacy `futimes` wasi-libc does not provide `futimes` as it is a legacy function. https://github.com/WebAssembly/wasi-libc/blob/574b88da481569b65a237cb80daf9a2d5aeaf82d/libc-top-half/musl/include/sys/time.h#L34
|
@swift-ci please test |
itingliu
approved these changes
Dec 17, 2024
|
Anything holding this up? I need it for Android too. |
|
I'm waiting @parkera's approval just in case. |
|
@parkera, just need your approval here, can get this in. |
|
@kateinoigakukun, please add my Android change from main, 90700c1, to this pull, would like to get that into 6.1 also. |
Normal users don't have permission to change these, even for their own files.
|
@swift-ci test |
|
Thanks, Yuta. @itingliu, OK to merge? Most of this pull is gated to WASI and Android, other than the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fix build issues in WASI platform, which are introduced in #1083
Scope: Impacts FileManager.copyItem(atPath:toPath:) on non-Windows platforms
Original PR: #1094 and #1095
Risk: Low - replace a legacy libc function call with a modern one, gate a few parts behind
os(WASI)Testing: swift-ci testing
Reviewer: @jmschonfeld