Destinations: throw error on duplicate artifact ID #6343
Merged
+270
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
|
@swift-ci smoke test |
`swift experimental-destination install` command doesn't check if a newly installed bundle contains same IDs as already installed bundles. Moved installation code from `InstallDestination.swift` to separate static functions on `DestinationBundle` to make it testable. Also added tests that exercise these code paths and verify that installation is successful or throws correct errors when needed. rdar://106090132
MaxDesiatov
force-pushed
the
maxd/duplicate-bundles
branch
from
7641e01 to
673999b
Compare
|
@swift-ci smoke test |
|
@swift-ci test windows |
|
@swift-ci smoke test |
|
@swift-ci test windows |
neonichu
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift experimental-destination installcommand doesn't check if a newly installed bundle contains same IDs as already installed bundles.Moved installation code from
InstallDestination.swiftto separate static functions onDestinationBundleto make it testable. Also added tests that exercise these code paths and verify that installation is successful or throws correct errors when needed.rdar://106090132