[Concurrency] Make initial executor construction fully thread safe. #81326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had originally thought that we'd get away without this because the executor construction generally happens in the async `main` function, but of course if a program doesn't already use Swift Concurrency, and someone uses it from a plug-in or library it loads, there's a risk that we might have a race condition. rdar://149346132
|
Explanation: This fixes an issue where if a program that doesn't use Swift Concurrency itself loads a library that does, and that library is multithreaded, we can end up with a race condition trying to initialise the executors. |
|
@swift-ci Please test |
ktoso
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had originally thought that we'd get away without this because the executor construction generally happens in the async
mainfunction, but of course if a program doesn't already use Swift Concurrency, and someone uses it from a plug-in or library it loads, there's a risk that we might have a race condition.rdar://150753884