[Swiftify] Skip swiftify during symbolic import #81349
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftify cannot work in this mode. This mode has been removed entirely in main. This takes a smaller change into the release to minimise risk. rdar://149953125
|
@swift-ci please test |
DougGregor
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swiftify does not, and can not, work in the symbolic import mode. This skips swiftify when that mode is enabled.
This should not affect compilation. It doesn't seem like symbolic imports are really used. They have been removed in main in [cxx-interop] Remove symbolic import mode #81257, but this is a smaller change to fix a specific issue that should carry less risk to the release.
rdar://149953125
Not really applicable since importSymbolicCXXDecls is no longer a thing in main, but [cxx-interop] Remove symbolic import mode #81257 would be the closes thing.
Low
User testing in Xcode
No original change, see above