🍒 [demangling] add new methods to the NodePrinter to enable range tracking possibilities when demangling a name #82479
+1,018
−867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Add new methods to the
NodePrinter
class, which allow children classes to track the range of various parts of the demangled, such as the name and parameters.Scope:
The changes in this PR apply to the demangling mechanism and should be almost be NFC, as we are just refactoring code by making some methods virtual. We are also adding 2 new variants of an already existing API
demangleSymbolAsString
.Issues:
Original PRs:
Risk:
Low, the changes are almost NFC.
Testing:
Built against the LLVM patches which add demangling syntax highlighting. I have tested debugging sample program and everything behaved as expected.
Reviewers: