-
-
Notifications
You must be signed in to change notification settings - Fork 196
Fix problem of overwriting envs #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a58bec5
to
45e37a9
Compare
Not sure how to fix:
|
@@ -114,7 +115,7 @@ class DockerComposeConfiguratorTest extends TestCase | |||
/** @var DockerComposeConfigurator */ | |||
private $configurator; | |||
|
|||
/** @var Package */ | |||
/** @var PackageInterface */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying here to fix: https://github.com/symfony/flex/runs/5509940830?check_suite_focus=true
But still errors this way: https://github.com/symfony/flex/runs/5510160271?check_suite_focus=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the error message you see here are coming from the mock configuration. So that's unrelated to that phpdoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the right fix is to make it use a RootPackage instead of a Package for this property (but also for the actual value, not just for the comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx that seems to fix the tests 👍 Had todo the same for LockArrayRepository in FlexTest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For backwards compatibility to composer 1.0.2 there a class_exists had to be added.
@@ -114,7 +115,7 @@ class DockerComposeConfiguratorTest extends TestCase | |||
/** @var DockerComposeConfigurator */ | |||
private $configurator; | |||
|
|||
/** @var Package */ | |||
/** @var PackageInterface */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the error message you see here are coming from the mock configuration. So that's unrelated to that phpdoc
@@ -114,7 +115,7 @@ class DockerComposeConfiguratorTest extends TestCase | |||
/** @var DockerComposeConfigurator */ | |||
private $configurator; | |||
|
|||
/** @var Package */ | |||
/** @var PackageInterface */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the right fix is to make it use a RootPackage instead of a Package for this property (but also for the actual value, not just for the comment)
dd910e1
to
84ca6e4
Compare
Thank you @alexander-schranz. |
Fixes problem of flex overwriting bundles.php envs.
Fixes #879 which currently breaks @sulu skeleton installation.