Native Firefox support (through geckodriver) #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierstoval
reviewed
Apr 9, 2018
stof
reviewed
Feb 19, 2020
Pierstoval
reviewed
Feb 19, 2020
| @@ -85,6 +85,9 @@ This listener will start the web server on demand like previously, but it will s | |||
| require __DIR__.'/vendor/autoload.php'; // Composer's autoloader | |||
|
|
|||
| $client = \Symfony\Component\Panther\Client::createChromeClient(); | |||
| // Or, if you care about the open web and prefer to use Firefox | |||
Pierstoval
reviewed
Feb 19, 2020
src/DomCrawler/Link.php
Outdated
| @@ -54,6 +55,6 @@ protected function setNode(\DOMElement $node) | |||
|
|
|||
| protected function getRawUri() | |||
| { | |||
| return $this->element->getAttribute('href'); | |||
| return $this->element->getAttribute('href') ?? ''; | |||
There was a problem hiding this comment.
Shouldn't it return the current URI?
Suggested change
| return $this->element->getAttribute('href') ?? ''; | |
| return $this->element->getAttribute('href') ?: $this->currentUri; |
| @@ -80,6 +80,7 @@ trait PantherTestCaseTrait | |||
| 'router' => '', | |||
| 'external_base_uri' => null, | |||
| 'readinessPath' => '', | |||
| 'browser' => self::CHROME, | |||
There was a problem hiding this comment.
Why not firefox as base? 🦊
There was a problem hiding this comment.
Because it's a huge BC break, and because Chrome is more used (unfortunately): 64% for Chrome, 5% for Firefox.
|
For an unknown reason, Travis uses an outdated version of |
dunglas
added a commit
that referenced
this pull request
Dec 28, 2020
* Native Firefox support (through geckodriver) * Fix CS * Remove VCS repo * Cleanup * Fix lint * Use cast instead of the null coalescing operator
nicolas-grekas
pushed a commit
that referenced
this pull request
Jan 18, 2021
* Native Firefox support (through geckodriver) * Fix CS * Remove VCS repo * Cleanup * Fix lint * Use cast instead of the null coalescing operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use Firefox as browser. The only requirement is to have Firefox installed.
Usage:
Or in a test case:
Needs php-webdriver/php-webdriver#560.