Skip to content

Drop support for PHP 7.1 #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Drop support for PHP 7.1 #428

wants to merge 1 commit into from

Conversation

derrabus
Copy link
Member

With the sunset of Symfony 4, we don't need to support PHP 7.1 anymore.

This PR proposes to bump all polyfill packages to PHP 7.2. This also applies to symfony/polyfill-php72 which basically becomes an empty package now and can be removed from the subtree split after its next release.

@nicolas-grekas
Copy link
Member

🤔 I don't think we need to do this. It's expected for polyfills to support old versions to me. + looking at the diff, this look unneeded, from a technical pov.

Instead, we could decide that new polyfills shouldn't support PHP 7. That'd allow making them more accurate, thanks to better type declarations.

@derrabus
Copy link
Member Author

Sure, we don't need to. I just thought, it would make #426 and possibly other future contributions easier.

@stof
Copy link
Member

stof commented Jan 31, 2023

Well, "future contributions" being easier depend on which PHP version changed the behavior of a function (as that's what made #426 require a different handling for PHP 7.1 vs 7.2+). And the code needed to support PHP 7.1 was still easy IMO.

I would not do this min version bump for now. I totally expect polyfills to support old PHP versions.

@derrabus
Copy link
Member Author

All right, let's not.

@derrabus derrabus closed this Jan 31, 2023
@derrabus derrabus deleted the bump/php branch January 31, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants