[Forms] Added data-mapper docs #10756
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Dec 10, 2018
|
|
||
| The red, green and blue form fields have to be mapped to the constructor | ||
| arguments and the ``Color`` instance has to be mapped to red, green and blue | ||
| form fields. Recognize a familiar pattern? It's time for a data mapper! |
There was a problem hiding this comment.
Maybe end this sentence with a colon.
There was a problem hiding this comment.
I think that ! brings some more joy and interaction here :)
form/data_mappers.rst
Outdated
|
|
||
| .. tip:: | ||
|
|
||
| You can also implement ``DataMapperInterface`` in the ``ColorType`` and add |
There was a problem hiding this comment.
[...] implement the DataMapperInterface [...]
There was a problem hiding this comment.
Should we also talk about the possibility to implement the data mapper as an anonymous class?
There was a problem hiding this comment.
I think in this very case when we have two rather complicated methods to implement, an anonymous class will be harder to read.
|
@xabbuh , thank you for review, addressed your comments. |
|
Thank you @vudaltsov. |
xabbuh
added a commit
that referenced
this pull request
Dec 11, 2018
This PR was squashed before being merged into the 3.4 branch (closes #10756). Discussion ---------- [Forms] Added data-mapper docs #SymfonyConHackday2018 Improved version of #6900 Thank you @wouterj for a great job and the initial text! Thanx @HeahDude for helping me with this PR. Commits ------- b1cb1c0 [Forms] Added data-mapper docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#SymfonyConHackday2018
Improved version of #6900
Thank you @wouterj for a great job and the initial text! Thanx @HeahDude for helping me with this PR.