Skip to content

remove space before self closing xml tag #11142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

OskarStark
Copy link
Contributor

to be consistent throughout the docs

to be consistent throughout the docs
@HeahDude
Copy link
Contributor

I am not sure about that one, because I think we need no space only for multilined opening tags:

<tag name="xx"
    class="xxx">
...

Versus

<tag name="xx" class="xxx" />

@HeahDude HeahDude added this to the 3.4 milestone Mar 12, 2019
@OskarStark
Copy link
Contributor Author

Hey @HeahDude

Sorry I don't really get what you mean. This change will only bring consistency throughout the docs, that all self closing (no matter if they are written multiline or not) xml tags look like /> instead of /> (with a space).

After that one we can enforce it by tool, have less merge conflicts, better diffs and we are less error prone by humans (lets call it an error if someone will write /> in the future 😄 ).

I already talked to @weaverryan @javiereguiluz and @xabbuh before I created this PR.

But maybe I missunderstand your comment 😄 🍺

@wouterj
Copy link
Member

wouterj commented Mar 16, 2019

Thanks Oskar! I fully agree with these changes, the space was only added to not confuse the HTML parser in xHTML documents, we should not use it in XML.

Note that I have been a very lazy merger. I've not bothered looking at the 50+ merge conflicts and instead ran git checkout --ours .. So all merge conflicts now are solved using the 4.2 version, instead of the modified 3.4 version of this PR. However, I assume you use a tool to create this diff, so you should be able to redo all those changes on the 4.2 branch easily.

wouterj added a commit that referenced this pull request Mar 16, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

remove space before self closing xml tag

to be consistent throughout the docs

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

d149921 remove space before self closing xml tag
@wouterj wouterj merged commit d149921 into symfony:3.4 Mar 16, 2019
@OskarStark OskarStark deleted the remove-spaces-before-self-closing-xml-tags branch March 16, 2019 19:34
@OskarStark
Copy link
Contributor Author

so you should be able to redo all those changes on the 4.2 branch easily.

sure thing, I will check the 4.2 branch 👍

wouterj added a commit that referenced this pull request Mar 16, 2019
This PR was merged into the 4.2 branch.

Discussion
----------

remove space before self closing xml tag

@wouterj this one is following your [comment](#11142 (comment))

Commits
-------

db87ab5 remove space before self closing xml tag
xabbuh added a commit that referenced this pull request Mar 22, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

removed blank line and space

Refs #11142 #11175
Refs #11138 #11140

Commits
-------

ecceb77 removed blank line and space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants