-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
remove space before self closing xml tag #11142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove space before self closing xml tag #11142
Conversation
to be consistent throughout the docs
I am not sure about that one, because I think we need no space only for multilined opening tags: <tag name="xx"
class="xxx">
... Versus <tag name="xx" class="xxx" /> |
Hey @HeahDude Sorry I don't really get what you mean. This change will only bring consistency throughout the docs, that all self closing (no matter if they are written multiline or not) xml tags look like After that one we can enforce it by tool, have less merge conflicts, better diffs and we are less error prone by humans (lets call it an error if someone will write I already talked to @weaverryan @javiereguiluz and @xabbuh before I created this PR. But maybe I missunderstand your comment 😄 🍺 |
Thanks Oskar! I fully agree with these changes, the space was only added to not confuse the HTML parser in xHTML documents, we should not use it in XML. Note that I have been a very lazy merger. I've not bothered looking at the 50+ merge conflicts and instead ran |
This PR was merged into the 3.4 branch. Discussion ---------- remove space before self closing xml tag to be consistent throughout the docs <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- d149921 remove space before self closing xml tag
sure thing, I will check the |
This PR was merged into the 4.2 branch. Discussion ---------- remove space before self closing xml tag @wouterj this one is following your [comment](#11142 (comment)) Commits ------- db87ab5 remove space before self closing xml tag
to be consistent throughout the docs