Skip to content

Added missing closing parentheses and closing bracket #12573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2019
Merged

Added missing closing parentheses and closing bracket #12573

merged 1 commit into from
Oct 31, 2019

Conversation

phoefnagel
Copy link
Contributor

@phoefnagel phoefnagel commented Oct 31, 2019 •
edited
Loading

Noticed they were missing so I added them.

javiereguiluz
javiereguiluz approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks Peter ... and congrats on your first Symfony Docs contribution!

Note to mergers: merge it in 4.3 branch. Thanks.

@javiereguiluz javiereguiluz added this to the 4.3 milestone Oct 31, 2019
@OskarStark OskarStark changed the base branch from master to 4.3 October 31, 2019 15:05
@OskarStark
Copy link
Contributor

... and one more bug fixed, thank you Peter.

OskarStark added a commit that referenced this pull request Oct 31, 2019
@OskarStark
bug #12573 Added missing closing parentheses and closing bracket (pho…
3dc9188 
…efnagel)

This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #12573).

Discussion
----------

Added missing closing parentheses and closing bracket

Noticed they were missing so I added them.

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

43a239b Missing closing parentheses and closing bracket
@OskarStark OskarStark merged commit 43a239b into symfony:4.3 Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@OskarStark OskarStark OskarStark approved these changes

@gregurco gregurco gregurco approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@phoefnagel @OskarStark @javiereguiluz @gregurco @carsonbot