[Mercure] update mercure doc to add clarification in authorization #12779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dunglas could you please review this proposal? Thanks! |
rooselle
changed the title
javiereguiluz
force-pushed
the
fix_dunglas_mercure_65
branch
from
e59c825 to
e6080ae
Compare
|
Chloé thanks and congrats on your first Symfony Docs contribution 🎉 I'm sorry it took us so long to merge. |
|
No problem Javier, better late than never :) Thanks a lot for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
I've added a few words and a code example to clarify the doc about authorization in the Mercure Bundle, to indicate that the
withCredentialsattribute of theEventSourcemust be set totruefor the authorization cookie to be sent to the Hub. I was missing this info when I installed Mercure for the first time (super protocol, by the way!) and learned about it while reading comments in response to an issue.By the way, this pull request should fix the closed issue dunglas/mercure#65.
Thanks in advance and have a nice day!
(This is my first pull request ever to an open-source project, all the more so to the Symfony repository, so I hope I did everything right.)