Skip to content

Using a Factory to Create Services: Add working usage example. #13170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: 5.4
Choose a base branch
from
Open

Using a Factory to Create Services: Add working usage example. #13170

wants to merge 8 commits into from

Conversation

BooleanType
Copy link
Contributor

No description provided.

OskarStark
OskarStark reviewed Feb 17, 2020
View reviewed changes
OskarStark
OskarStark reviewed Feb 19, 2020
View reviewed changes
@BooleanType BooleanType requested a review from xabbuh as a code owner March 23, 2021 13:54
@BooleanType
Copy link
Contributor Author

BooleanType commented Mar 23, 2021 •
edited
Loading

Hello!
Sorry for soooo long pause. I'm still here :)
I've pushed some changes:
- DeliveryFactory is not an abstract class anymore;
- little refactoring has been made;
- some mistakes are fixed.
PS. Sorry for that mess with other members commits history in my current pull request. My project version is out-of-date, but I didn't want to create new pull request for 5.2 version for the same topic. So I decided to rebase everything, as it explained here. Hope I've done it right. I still can close this PR for 5.0 and create new one for 5.2, if it's needed.

@xabbuh xabbuh changed the base branch from 5.0 to 5.2 March 23, 2021 14:48
@xabbuh xabbuh changed the base branch from 5.2 to 5.x March 23, 2021 18:17
@BooleanType
Copy link
Contributor Author

Hello-hello :) So what about my proposition to add this example into the documentation?

@BooleanType
Copy link
Contributor Author

@xabbuh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@HeahDude HeahDude HeahDude left review comments

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BooleanType @OskarStark @HeahDude @carsonbot