Skip to content

Messenger process managers #13597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Messenger process managers #13597

merged 2 commits into from
Sep 6, 2022

Conversation

tvlooy
Copy link
Contributor

@tvlooy tvlooy commented Apr 27, 2020

Add information about mysql timeouts, supervisor FATAL, systemd user services.

Or, how should you handle this MySQL timeout issue, supervisor restart (FATAL) issues? How do you people do this? What does the component author thinks about this?

I myself am using with systemd user services in production for a while and it's running okay.

@tvlooy tvlooy force-pushed the patch-1 branch 2 times, most recently from 80f531d to 96f6f40 Compare April 27, 2020 18:08
@tvlooy tvlooy force-pushed the patch-1 branch 2 times, most recently from 8d045ff to bbcc618 Compare May 4, 2020 20:48
@tvlooy
Copy link
Contributor Author

tvlooy commented May 18, 2020

did some polishing. This PR is ready

@tvlooy tvlooy force-pushed the patch-1 branch 2 times, most recently from c486cdb to 6b27c14 Compare May 18, 2020 20:45
Copy link

@vicla31 vicla31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FI, [Unit] section of service allow "Requires=" which could be set to prevent failure from dependency not meet a startup

@wouterj wouterj added the help wanted Issues and PRs which are looking for volunteers to complete them. label Dec 3, 2020
@OskarStark OskarStark added this to the 5.1 milestone Dec 7, 2020
@OskarStark
Copy link
Contributor

OskarStark commented Dec 7, 2020

@tvlooy can you please retarget to 5.1? Thanks

@tvlooy
Copy link
Contributor Author

tvlooy commented Dec 10, 2020

FI, [Unit] section of service allow "Requires=" which could be set to prevent failure from dependency not meet a startup

What would you suggest as a Requires? After=network.target rabbitmq.service something like that? I don't do that for my services atm

@tvlooy tvlooy changed the base branch from 5.0 to 5.1 December 10, 2020 07:56
@tvlooy
Copy link
Contributor Author

tvlooy commented Dec 10, 2020

@OskarStark thanks for the review!

@tvlooy
Copy link
Contributor Author

tvlooy commented Jun 25, 2021

No interest in merging this?

@icanhazstring
Copy link

Please merge this, as I was looking days for a solution on supervisor. Thanks to @tvlooy we managed to implement the wrapper script which added the needed delay between restarts. As the PR for supervisor does not provide this.
Supervisor/supervisor#487

So a merge would be nice for the world to know :)

tvlooy and others added 2 commits September 6, 2022 17:27
Add information about mysql timeouts, supervisor FATAL, systemd user services.
Add docs for symfony#13617
This feature seems to be the official way to handle delays in restart.
@wouterj wouterj changed the base branch from 5.1 to 5.4 September 6, 2022 15:29
@wouterj wouterj merged commit 167259d into symfony:5.4 Sep 6, 2022
@wouterj
Copy link
Member

wouterj commented Sep 6, 2022

Hi @tvlooy! Thanks a lot for sharing this knowledge by contributing to the docs. Having this expert information in the docs is great, but - as you noticed - it's also hard to review/merge as we aren't necessarily expert on the topic ourselves :)

As a side note: this type of information is often great for a personal blog post. In that way, you can still help the community by sharing your knowledge and it's often a lot "lighter" (having the official stamp on the docs means we have to be very careful on what to recommend).

Nonetheless, I think having a systemd example in the documentation is great and looking at the comments in this PR, the community is looking for a way to avoid FATAL states.

Reading the Supervisor issue referenced by @icanhazstring, I found out about Supervisor's BACKOFF strategy: Supervisor/supervisor#487 (comment) I've decided to document that instead of your bash helper script, as it feels more official. Let me know if you think this doesn't work for what you intended to solve :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues and PRs which are looking for volunteers to complete them. Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.