Skip to content

[Serializer] Add an @Ignore annotation #28744 #13701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2020
Merged

[Serializer] Add an @Ignore annotation #28744 #13701

merged 3 commits into from
Sep 3, 2020

Conversation

vasilvestre
Copy link
Contributor

@vasilvestre vasilvestre commented May 24, 2020

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vasilvestre thanks for contributing these docs. I left some comments about some minor things, but overall it looks OK to me 👍

@vasilvestre vasilvestre requested a review from javiereguiluz May 25, 2020 12:42
Copy link
Contributor

@noniagriconomie noniagriconomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small code changes required after renaming MyObj in favor of MyClass

Update serializer.rst
Update components/serializer.rst

Co-authored-by: Oskar Stark <[email protected]>
Update components/serializer.rst

Co-authored-by: Antoine Makdessi <[email protected]>
Update components/serializer.rst

Co-authored-by: Antoine Makdessi <[email protected]>
Update components/serializer.rst

Co-authored-by: Oskar Stark <[email protected]>
Update components/serializer.rst

Co-authored-by: Antoine Makdessi <[email protected]>
Update serializer.rst
@vasilvestre
Copy link
Contributor Author

@javiereguiluz I think this should be good now !

Remove default value (false) from ignoring rules in XML and YML files as I didn't put them in PHP code.
@javiereguiluz javiereguiluz added this to the 5.2 milestone Sep 3, 2020
@javiereguiluz javiereguiluz merged commit 6d11c55 into symfony:master Sep 3, 2020
@javiereguiluz
Copy link
Member

Valentin, thanks a lot for your contribution ... and congrats on your very first contribution to Symfony Docs 🎉

@vasilvestre vasilvestre deleted the document-ignore-annotation branch September 4, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Serializer] Add an @Ignore annotation
6 participants