Updated the doc for symfony/symfony#4497 #1440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
that referenced
this pull request
Jun 17, 2012
Updated the doc for symfony/symfony#4497
|
Hey Stof! Thanks for the PR. I'm curious exactly where the BC break was here - in the BrowserKit, FrameworkBundle? I couldn't find anything in a quick scan of the CHANGELOG's - perhaps it's missing or I'm misunderstanding exactly what changed here. Thanks! |
|
Nevermind - just noticed that you covered this in your PR subject! |
|
actually, @fabpot reverted the PR meaning that symfony/symfony#4475 still needs to be fixed (and this PR should have wait a new fix) |
|
Hmm, looks like we indeed need to wait then. I'm going to revert this since since symfony/symfony#4497 was reverted, and then we'll make any necessary changes going forward. Thanks @stof for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response returned by
getResponseis now the BrowserKit Response (as specified in the phpdoc) instead of the HttpFoundation Response.