Prefer sass over node-sass #14649
Closed
Prefer sass over node-sass #14649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Dec 3, 2020
|
Shouldn't this go in 4.4? 🧐 |
|
@OskarStark yes! The front-end stuff is (almost always) independent from the Symfony version, so let's merge it in the lowest maintained branch. Thanks! |
|
Thanks Ryan. #SymfonyHackday |
wouterj
added a commit
that referenced
this pull request
Dec 5, 2020
This PR was submitted for the 5.2 branch but it was merged into the 4.4 branch instead. Discussion ---------- Prefer sass over node-sass Hi! `node-sass` is deprecated in favor of `sass` - https://sass-lang.com/blog/libsass-is-deprecated. Encore works exactly the same with both, and `sass` doesn't require an annoying compile step that sometimes fails anyways. And also, here is the PR that will change which library is recommended: symfony/webpack-encore#870 I will merge and tag that shortly. Commits ------- 41418b7 Prefer sass over node-sass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
node-sassis deprecated in favor ofsass- https://sass-lang.com/blog/libsass-is-deprecated. Encore works exactly the same with both, andsassdoesn't require an annoying compile step that sometimes fails anyways.And also, here is the PR that will change which library is recommended: symfony/webpack-encore#870
I will merge and tag that shortly.