[Twig reference] Changed the way label attributes are passed in examples #1542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been changed in symfony/symfony@167e64f but was not reflected in the documentation.
|
Oh, and this is too bad that attributes have to be passed an other way for labels... I'm not sure if there is a workaround for this. Any thoughts? |
|
Could you please remove the space after |
|
@michaelperrin This is done on purpose. Otherwise, when passing attributes to |
…ell, and do it everywhere else as well
|
@stof Thanks for the explanation :) |
|
@wouterj I think it's now ready for merging! |
weaverryan
added a commit
that referenced
this pull request
Jul 15, 2012
[Twig reference] Changed the way label attributes are passed in examples
craigmarvelley
pushed a commit
to craigmarvelley/symfony
that referenced
this pull request
Nov 26, 2013
Commits ------- 81eb722 Simpler sentence concerning upgrade of the form_label function f6f1bb5 Update to the "Upgrade to v2.1" documentation: the way HTML attributes are passed for the `form_label` function has changed. Discussion ---------- Update upgrade to 2.1 documentation concerning form_label The way HTML attributes are passed for the `form_label` function has changed since this commit : symfony@167e64f I also made a PR for the documentation: symfony/symfony-docs#1542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way label attributes are passed changed in symfony/symfony@167e64f but it was not reflected in the documentation.